-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(e2e): Use current directory so e2e test won't complain about directory not exists #2693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we add this to the |
Yeah, the directory should be marked as ignored. |
Also shouldn't we disable screenshots when developing locally? I feel like they would stack up a lot. |
@tinayuangao that's another good point- @devversion @crisbeto is there an easy way for the screenshot utility to know if it's local? I'd assume there's an environment variable we can check. |
Use process.env['TRAVIS'] to check whether it's local. Please take another look. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah checking the TRAVIS
variable is the right way. LGTM
Just one question, how can we take a look at those screenshots on the CI?
|
Currently there's no way to take a look. We will upload the images, compare them and generate a report later. |
@tinayuangao Cool. I have some nice ideas about displaying those reports since we also have data about the payload size etc. Edit: Removing the LGTM label as @jelbourn is the intended reviewer 😄 |
LGTM |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
R: @jelbourn