Skip to content

fix(e2e): Use current directory so e2e test won't complain about directory not exists #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2017

Conversation

tinayuangao
Copy link
Contributor

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 17, 2017
@devversion
Copy link
Member

Should we add this to the .gitignore?

@jelbourn
Copy link
Member

Yeah, the directory should be marked as ignored.

@crisbeto
Copy link
Member

crisbeto commented Jan 17, 2017

Also shouldn't we disable screenshots when developing locally? I feel like they would stack up a lot.

@jelbourn
Copy link
Member

@tinayuangao that's another good point- @devversion @crisbeto is there an easy way for the screenshot utility to know if it's local? I'd assume there's an environment variable we can check.

@tinayuangao
Copy link
Contributor Author

Use process.env['TRAVIS'] to check whether it's local. Please take another look. Thanks!

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah checking the TRAVIS variable is the right way. LGTM

@devversion
Copy link
Member

devversion commented Jan 18, 2017

Just one question, how can we take a look at those screenshots on the CI?

It's probably for the screenshot-diffs?

@tinayuangao
Copy link
Contributor Author

Just one question, how can we take a look at those screenshots on the CI?

Currently there's no way to take a look. We will upload the images, compare them and generate a report later.

@devversion
Copy link
Member

devversion commented Jan 18, 2017

@tinayuangao Cool. I have some nice ideas about displaying those reports since we also have data about the payload size etc.

Edit: Removing the LGTM label as @jelbourn is the intended reviewer 😄

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 20, 2017
@mmalerba mmalerba merged commit aab6aee into angular:master Jan 20, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants