refactor(material/button): clean up fab tokens #27994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
Reworks the tokens setup for the FAB by: * Introducing a custom tokens map. It was necessary both for these changes and will come in handy later for the ripples. * Using tokens specifically for the disabled state instead of passing in the non-disabled ones. This aligns the FAB with the rest of the library and allows us to reduce the specificity. * Introducing a tokens specifically for the icon/text color. Currently we have an ad-hoc variable declared directly in the component styles. * Using our own mixins for the elevation instead of MDC's. Our mixin calls into MDC eventually, but it has some safeguards as well. * Generating the tokens that we pass into MDC's theme using our APIs, instead of creating the map directly.
crisbeto
force-pushed
the
fab-tokens-fixup
branch
from
8a37fe7 to
290b109
Compare
wagnermaciel
approved these changes
Oct 25, 2023
crisbeto
added a commit
that referenced
this pull request
Oct 25, 2023
Reworks the tokens setup for the FAB by: * Introducing a custom tokens map. It was necessary both for these changes and will come in handy later for the ripples. * Using tokens specifically for the disabled state instead of passing in the non-disabled ones. This aligns the FAB with the rest of the library and allows us to reduce the specificity. * Introducing a tokens specifically for the icon/text color. Currently we have an ad-hoc variable declared directly in the component styles. * Using our own mixins for the elevation instead of MDC's. Our mixin calls into MDC eventually, but it has some safeguards as well. * Generating the tokens that we pass into MDC's theme using our APIs, instead of creating the map directly. (cherry picked from commit e9fc04d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the tokens setup for the FAB by: