Skip to content

docs(material/slider): value should go in the input tag #28257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

mruanova
Copy link
Contributor

@mruanova mruanova commented Dec 10, 2023

this screen is correct
Screen Shot 2023-12-09 at 8 12 10 PM
but this screen is wrong because the value should go in the input tag
Screen Shot 2023-12-09 at 8 13 10 PM

@mruanova mruanova requested a review from devversion as a code owner December 10, 2023 02:11
Copy link

google-cla bot commented Dec 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mruanova mruanova changed the title src/material/slider/slider.md docs(material/slider): value should go in the input tag Dec 12, 2023
@mruanova
Copy link
Contributor Author

corrected title of the pull request to satisfy lint

@crisbeto
Copy link
Member

The lint failure can be fixed when merging the change, but it looks like the CLA isn't signed. See https://github.com/angular/components/blob/main/CONTRIBUTING.md#cla

@devversion devversion removed their request for review December 17, 2023 11:49
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 9, 2024
@mmalerba mmalerba self-assigned this Jan 9, 2024
@mmalerba
Copy link
Contributor

@mruanova This is ready to merge in if you can sign the CLA - thanks!

@mruanova
Copy link
Contributor Author

@mruanova This is ready to merge in if you can sign the CLA - thanks!

CLA signed

@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 10, 2024
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Apr 11, 2024
@mmalerba mmalerba merged commit 1999e20 into angular:main Apr 11, 2024
mmalerba pushed a commit that referenced this pull request Apr 11, 2024
* src/material/slider/slider.md

* slider

* slider

* docs(material/slider): value should go in the input tag

* docs(material/slider): value should go in the input tag

(cherry picked from commit 1999e20)
@mruanova mruanova deleted the src/material/slider/slider.md branch April 11, 2024 19:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants