-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(material/slider): value should go in the input tag #28257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(material/slider): value should go in the input tag #28257
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
corrected title of the pull request to satisfy lint |
The lint failure can be fixed when merging the change, but it looks like the CLA isn't signed. See https://github.com/angular/components/blob/main/CONTRIBUTING.md#cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mruanova This is ready to merge in if you can sign the CLA - thanks! |
CLA signed |
* src/material/slider/slider.md * slider * slider * docs(material/slider): value should go in the input tag * docs(material/slider): value should go in the input tag (cherry picked from commit 1999e20)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
this screen is correct


but this screen is wrong because the value should go in the input tag