Skip to content

fix(material/core): throw better error when mixin doesn't support color variants #28880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

crisbeto
Copy link
Member

Fixes that calling a theming mixin for a component that doesn't support color variants was throwing a cryptic error.

Fixes #28860.

…or variants

Fixes that calling a theming mixin for a component that doesn't support color variants was throwing a cryptic error.

Fixes angular#28860.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Apr 14, 2024
@crisbeto crisbeto requested a review from andrewseguin April 14, 2024 09:26
@crisbeto crisbeto requested a review from mmalerba as a code owner April 14, 2024 09:26
@crisbeto crisbeto removed the request for review from mmalerba April 15, 2024 20:02
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 15, 2024
@crisbeto crisbeto merged commit 8ec47aa into angular:main Apr 15, 2024
crisbeto added a commit that referenced this pull request Apr 15, 2024
…or variants (#28880)

Fixes that calling a theming mixin for a component that doesn't support color variants was throwing a cryptic error.

Fixes #28860.

(cherry picked from commit 8ec47aa)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(mat-button-toggle): button-toggle-color variants missing
2 participants