build: fix webdriver tests #28915
Merged
build: fix webdriver tests #28915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
crisbeto
force-pushed
the
webdriver-no-stable
branch
5 times, most recently
from
80eebe6 to
5a88610
Compare
Reworks the Webdriver tests to avoid the frequent timouts that we've been seeing. Working theory is that refreshing the page on each test and then waiting for Angular to stabizilize causes Webdriver to eventually time out. These changes switch to only loading the page once and resetting its state within the same session.
crisbeto
force-pushed
the
webdriver-no-stable
branch
from
5a88610 to
da1a89a
Compare
crisbeto
requested review from
andrewseguin,
mmalerba and
devversion
as code owners
wagnermaciel
approved these changes
Apr 22, 2024
crisbeto
removed request for
devversion,
zarend,
amysorto,
mmalerba and
andrewseguin
crisbeto
added a commit
that referenced
this pull request
Apr 22, 2024
Reworks the Webdriver tests to avoid the frequent timouts that we've been seeing. Working theory is that refreshing the page on each test and then waiting for Angular to stabizilize causes Webdriver to eventually time out. These changes switch to only loading the page once and resetting its state within the same session. (cherry picked from commit 971f83f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the Webdriver tests to avoid the frequent timouts that we've been seeing. Working theory is that refreshing the page on each test and then waiting for Angular to stabizilize causes Webdriver to eventually time out. These changes switch to only loading the page once and resetting its state within the same session.