docs(cdk/dialog): add initial setup instructions for CDK dialogs #29209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added instructions for including structural styles required by CDK dialogs. Noted that without importing '@angular/cdk/overlay-prebuilt.css' in the global stylesheet, CDK dialogs did not work correctly.
ifrntnd
requested review from
amysorto and
wagnermaciel
and removed request for
a team
crisbeto
reviewed
Jun 7, 2024
| The CDK dialogs depend on a small set of structural styles to work correctly. If you're using | ||
| Angular Material, these styles have been included together with the theme, otherwise if you're | ||
| using the CDK on its own, you'll have to include the styles yourself. You can do so by importing | ||
| the prebuilt styles in your global stylesheet: |
There was a problem hiding this comment.
Might be worth mentioning that one can also get these styles by including the cdk.overlay mixin.
There was a problem hiding this comment.
@crisbeto I've updated the instructions to include an alternative method using the cdk.overlay mixin in Sass.
Added alternative method for including CDK styles using the cdk.overlay mixin
crisbeto
approved these changes
Jun 7, 2024
crisbeto
added
action: merge
|
@ifrntnd I can't merge in the change because of the third merge commit. Can you drop it from the PR? |
ifrntnd
force-pushed
the
docs/update-cdk-dialog-setup
branch
from
3c1a194 to
5a0a595
Compare
crisbeto
approved these changes
Jun 8, 2024
crisbeto
pushed a commit
that referenced
this pull request
Jun 8, 2024
) * docs(cdk/dialog): add initial setup instructions for CDK dialogs Added instructions for including structural styles required by CDK dialogs. Noted that without importing '@angular/cdk/overlay-prebuilt.css' in the global stylesheet, CDK dialogs did not work correctly. * docs(cdk/dialog): added cdk.overlay mixin import Added alternative method for including CDK styles using the cdk.overlay mixin (cherry picked from commit 35f07c5)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added instructions for including structural styles required by CDK dialogs. Noted that without importing
@angular/cdk/overlay-prebuilt.cssin the global stylesheet, CDK dialogs did not work correctly.