Skip to content

build: update to TypeScript 5.5 #29217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024
Merged

build: update to TypeScript 5.5 #29217

merged 1 commit into from
Jun 10, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 9, 2024

Updates the repo to the latest Angular next version and TypeScript 5.5 RC.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jun 9, 2024
@crisbeto crisbeto requested a review from a team as a code owner June 9, 2024 07:06
@crisbeto crisbeto requested review from amysorto and wagnermaciel and removed request for a team June 9, 2024 07:06
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jun 9, 2024
@crisbeto crisbeto requested review from mmalerba and andrewseguin June 9, 2024 07:06
@crisbeto crisbeto force-pushed the ts-5.5-beta branch 8 times, most recently from d3256f0 to 69a9569 Compare June 10, 2024 06:55
@crisbeto crisbeto requested a review from devversion June 10, 2024 07:02
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 10, 2024
Updates the repo to the latest Angular `next` version and TypeScript 5.5 beta.
@@ -7,7 +7,7 @@
*/

// Workaround for: https://github.com/bazelbuild/rules_nodejs/issues/1265
/// <reference types="google.maps" />
/// <reference types="google.maps" preserve="true" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this caught by some integration tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah although the failure was a bit weird and took a while to track down. It was caught by the API extractor not being able to follow the type of the global variables.

@@ -0,0 +1,28 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we add these configs? (out of curiosity)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating the test apps stopped compiling because they couldn't find tslib. I couldn't track it down and assumed it was some Bazel issue so I ended up setting importHelpers: false.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 10, 2024
@crisbeto crisbeto merged commit 6fd57c2 into angular:main Jun 10, 2024
21 of 24 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants