-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: update to TypeScript 5.5 #29217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d3256f0
to
69a9569
Compare
Updates the repo to the latest Angular `next` version and TypeScript 5.5 beta.
@@ -7,7 +7,7 @@ | |||
*/ | |||
|
|||
// Workaround for: https://github.com/bazelbuild/rules_nodejs/issues/1265 | |||
/// <reference types="google.maps" /> | |||
/// <reference types="google.maps" preserve="true" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this caught by some integration tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah although the failure was a bit weird and took a while to track down. It was caught by the API extractor not being able to follow the type of the global variables.
@@ -0,0 +1,28 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we add these configs? (out of curiosity)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After updating the test apps stopped compiling because they couldn't find tslib. I couldn't track it down and assumed it was some Bazel issue so I ended up setting importHelpers: false.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates the repo to the latest Angular
next
version and TypeScript 5.5 RC.