fix(cdk-experimental/popover-edit): Fix dialog role and allow aria label on popup #29380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseamon
requested review from
amysorto and
mmalerba
and removed request for
a team
crisbeto
reviewed
Jul 5, 2024
kseamon
force-pushed
the
popover-edit-label
branch
from
f3ce925 to
4d0a0d5
Compare
crisbeto
approved these changes
Jul 8, 2024
crisbeto
added
action: merge
DBowen33
pushed a commit
to DBowen33/components
that referenced
this pull request
Jul 12, 2024
This was referenced Aug 8, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct role attribute and allow setting aria label on the dialog/popup element.
See internal ticket 349939031