Allow undefined & null values in [matTooltip] explicitly #29397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to use null/undefined types outright. We were using nullness assertions to cause these assignments to succeed, but we should allow users to set null/undefined values outright. Right now we don't, so this update will cause the tests to fail. But this will be soon fixed.
…ip]` explicitly. We have tests that already set these values (but used to use nullness assertions to overcome the build failures) and protect against it by treating these values as empty strings (and thus we hide the tooltip), but we don't allow anyone who uses templates with strict type checking to set optional values unless they add their own nullness assertion.
….message` getter as always a string. We do this since the underlying `._message` type is a string, the message setter can accept null and undefined values, but will convert them to strings before saving to `_message`, so we can always assume someone _reading_ the value will see a plain string.
mmalerba
approved these changes
Jul 8, 2024
angular-robot
bot
added
the
area: build & ci
mmalerba
added
target: minor
DBowen33
pushed a commit
to DBowen33/components
that referenced
this pull request
Jul 12, 2024
* fix(material/tooltip): Update MatTooltip's "message not present" test to use null/undefined types outright. We were using nullness assertions to cause these assignments to succeed, but we should allow users to set null/undefined values outright. Right now we don't, so this update will cause the tests to fail. But this will be soon fixed. * fix(material/tooltip): Allow null and undefined values for `[matTooltip]` explicitly. We have tests that already set these values (but used to use nullness assertions to overcome the build failures) and protect against it by treating these values as empty strings (and thus we hide the tooltip), but we don't allow anyone who uses templates with strict type checking to set optional values unless they add their own nullness assertion. * fix(material/tooltip): Also explicitly define the type of `MatTooltip.message` getter as always a string. We do this since the underlying `._message` type is a string, the message setter can accept null and undefined values, but will convert them to strings before saving to `_message`, so we can always assume someone _reading_ the value will see a plain string. * ci: Approve new API goldens for tooltip --------- Co-authored-by: Miles Malerba <[email protected]>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have tests that already set these values (but used to use nullness assertions to overcome the build failures) and protect against it by treating these values as empty strings (and thus we hide the tooltip), but we don't allow anyone who uses templates with strict type checking to set optional values unless they add their own nullness assertion.