Skip to content

refactor(material/core): use util to build token vars #29497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

andrewseguin
Copy link
Contributor

  • rename get-token-variable to get-token-variable-name
  • rename get-token-variable-reference to get-token-variable
  • switch uses of get-token-variable-name to get-token-variable (remove wrapper of "var" since function does this)

@andrewseguin andrewseguin force-pushed the rename-get-theme-token branch 3 times, most recently from eea27ac to 5c03925 Compare July 27, 2024 13:19
@andrewseguin andrewseguin force-pushed the rename-get-theme-token branch from 5c03925 to f31d72a Compare July 27, 2024 13:47
@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Jul 27, 2024
@andrewseguin andrewseguin marked this pull request as ready for review July 27, 2024 18:48
@andrewseguin andrewseguin requested a review from a team as a code owner July 27, 2024 18:48
@andrewseguin andrewseguin requested review from crisbeto and amysorto and removed request for a team July 27, 2024 18:48
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Jul 28, 2024
@andrewseguin andrewseguin removed the request for review from amysorto July 28, 2024 16:20
@andrewseguin andrewseguin merged commit b5bbda4 into angular:main Jul 29, 2024
21 of 24 checks passed
andrewseguin added a commit that referenced this pull request Jul 29, 2024
* refactor(material/core): use util to build token vars

* remove todo

(cherry picked from commit b5bbda4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants