Skip to content

fix(select): add font family property #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2017
Merged

fix(select): add font family property #2973

merged 1 commit into from
Feb 9, 2017

Conversation

LendsMan
Copy link

@LendsMan LendsMan commented Feb 7, 2017

Md-input-container and even md-option have font-families, but md-select does not.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 7, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 8, 2017
@kara kara changed the title Md-select has no Roboto font-family: fixes angular/material2#2970 fix(select): add font family property Feb 8, 2017
@@ -12,6 +13,7 @@ $md-select-panel-max-height: 256px !default;
md-select {
display: inline-block;
outline: none;
font-family: $md-font-family;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be $mat-font-family now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinayuangao Ok, updated.

@kara kara added pr: needs cleanup / tests and removed cla: yes PR author has agreed to Google's Contributor License Agreement action: merge The PR is ready for merge by the caretaker labels Feb 9, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 9, 2017
@kara kara added action: merge The PR is ready for merge by the caretaker and removed pr: needs cleanup / tests labels Feb 9, 2017
@tinayuangao tinayuangao merged commit be19b2d into angular:master Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants