Skip to content

chore: no longer use MaterialModule #4571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2017

Conversation

devversion
Copy link
Member

  • Replaces the MaterialModule with custom NgModules that contain all required Material modules.

Closes #4532

@devversion devversion requested a review from jelbourn May 15, 2017 19:32
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 15, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 15, 2017
@devversion devversion force-pushed the chore/no-kitchen-sink branch from 13355ac to 143c476 Compare May 17, 2017 21:16
@devversion
Copy link
Member Author

@jelbourn Is this merge safe?

@jelbourn
Copy link
Member

Nope, the demo app is actually built as part of the presubmit

@devversion
Copy link
Member Author

Good to know that.

* Replaces the `MaterialModule` with custom NgModules that contain all required Material modules.

Closes angular#4532
@devversion
Copy link
Member Author

Rebased @tinayuangao

@tinayuangao tinayuangao merged commit fa5b427 into angular:master May 22, 2017
@devversion devversion deleted the chore/no-kitchen-sink branch November 11, 2017 10:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some documentation still references the removed 'MaterialModule'
4 participants