docs(datepicker): explicitly mention i18n and warn people about pitfa… #4598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lls of using NativeDateAdapter
googlebot
added
the
cla: yes
|
Looks great. |
mmalerba
changed the title
jelbourn
reviewed
May 18, 2017
src/lib/datepicker/datepicker.md
Outdated
| native Date object, and is thus not suitable for many locales. One of the biggest shortcomings of | ||
| the native Date object is the inability to set the parse format. We highly recommend writing a | ||
| custom `DateAdapter` that works with the formatting/parsing library of your choice, or waiting for | ||
| the official Moment.js module.* |
There was a problem hiding this comment.
I would rephrase this to not convey that Moment is the "official" way of doing i18n, but just that we plan on making a moment adapter available as a convenience
There was a problem hiding this comment.
Ok, just removed the moment.js reference here since it's already mentioned in a few other places that we plan to make that
jelbourn
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lls of using NativeDateAdapter
@fxck