fix(chips): unable to tab out of chip list #4605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes not being able to escape focus from an `md-chip-list` backwards via shift+tab on all browsers. * Fixes not being able to tab out of an `md-chip-list` at all on Firefox. Fixes angular#4593.
googlebot
added
the
cla: yes
tinayuangao
reviewed
May 17, 2017
| @@ -59,11 +63,19 @@ export class MdChipList implements AfterContentInit { | |||
| /** The chip components contained within this chip list. */ | |||
| chips: QueryList<MdChip>; | |||
|
|
|||
| constructor(private _elementRef: ElementRef) { } | |||
| /** Tab index for the chip list. */ | |||
| _tabIndex = 0; | |||
There was a problem hiding this comment.
Why Shift+tab doesn't work on tabindex=0?
There was a problem hiding this comment.
It's because the browsers determine that the previous tabbable element is the parent (since the chips are tabindex="-1" and the chip list is tabindex="0"). When the parent receives focus, it forwards it back to the first chip. As an aside, Firefox also tabs into the parent when tabbing forward.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-chip-listbackwards via shift+tab on all browsers.md-chip-listat all on Firefox.Fixes #4593.