Skip to content

docs: add a doc about the scroll strategies #4630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2017

Conversation

crisbeto
Copy link
Member

Adds a quick readme regarding the scroll strategies.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 17, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor grammar comments

# Scroll strategies

## What is a scroll strategy?
A scroll strategy is a class that describes how an overlay should behave, if the user scrolls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comma necessary here

## What is a scroll strategy?
A scroll strategy is a class that describes how an overlay should behave, if the user scrolls
while the overlay is open. The strategy has a reference to the `OverlayRef`, allowing it to
recalculate the position, close the overlay, block scrolling etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma between "scrolling" and "etc."

Adds a quick readme regarding the scroll strategies.
@crisbeto crisbeto force-pushed the scroll-strategy-doc branch from f485a40 to d706f18 Compare May 17, 2017 21:54
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 17, 2017
@jelbourn jelbourn merged commit 4617a44 into angular:master May 18, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants