build: deploy screenshot functions #4698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
May 20, 2017
devversion
commented
- Deploys the screenshot functions for push builds
- Runs deploying & publishing in parallel
* Deploys the screenshot functions for push builds * Runs deploying & publishing in parallel
googlebot
added
the
cla: yes
jelbourn
reviewed
May 22, 2017
| # before it can collect all functions and deploy them. | ||
| (cd tools/screenshot-test/functions; npm install) | ||
|
|
||
| if [ -z ${MATERIAL2_SCREENSHOT_ACCESS_TOKEN} ]; then |
There was a problem hiding this comment.
Created MATERIAL2_SCREENSHOT_FIREBASE_DEPLOY_TOKEN for this
| @@ -30,8 +33,10 @@ publishPackage() { | |||
| repoUrl="https://github.com/angular/${packageRepo}.git" | |||
| repoDir="tmp/${packageRepo}" | |||
|
|
|||
| # Create a release of the current repository. | |||
| $(npm bin)/gulp ${packageName}:build-release:clean | |||
| if [[ ! ${COMMAND_ARGS} == *--no-build* ]]; then | |||
There was a problem hiding this comment.
This allows us to decide whether the script itself should build or if we want to build the output before on our own.
This allows us to run publishing & deploying in parallel.
You can still run the script without any flag to build it as usual.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.