Skip to content

docs(card): add guidance for a11y #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2017
Merged

docs(card): add guidance for a11y #4781

merged 1 commit into from
Jun 7, 2017

Conversation

jelbourn
Copy link
Member

Also cleaned up some unnecessary class bindings while I was touching card.

@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation pr: needs review labels May 24, 2017
@jelbourn jelbourn requested a review from mmalerba May 24, 2017 18:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 24, 2017
@jelbourn jelbourn requested a review from andrewseguin May 30, 2017 22:28
@jelbourn jelbourn mentioned this pull request May 31, 2017
Closed
andrewseguin
andrewseguin approved these changes Jun 6, 2017
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 6, 2017
@andrewseguin andrewseguin merged commit 4fcab57 into angular:master Jun 7, 2017
@jelbourn jelbourn deleted the card-a11y branch September 13, 2017 04:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

@andrewseguin andrewseguin

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @andrewseguin @googlebot @mmalerba