build: move release packages to constants

[devversion]

• Moves the list of packages that should be released to the constants file.
• Sets the executable bit flag on the deploy-screenshot-functions.sh script

[jelbourn]

I don't really like this; I don't see why have a constants.ts file full of unrelated things is better than having the constant for release packages defined where it's used.

[devversion]

This way you can find stuff better and it can be like a config. It's probably a kind of similar question about having a configuration file for Pixacto (for sure not the same)

[devversion]

This could be theoretically also a config.json file that configures out build tasks.

[jelbourn]

Ah, you mean it to be like a configuration for a re-usable library. That makes more sense. In that case I'd be okay with it if we rename the file "build-config.ts" for now.

[devversion]

Yeah sorry if it was confusing. Let's also try to get rid of all the path constants in a follow-up then?

Because I don't think it makes sense to store constants like DIST_MATERIAL in a config?

[jelbourn]

Probably would make more sense to just have distRoot and then the output for each package does into a subdir of that.

[devversion]

Yeah you would just configure the output folder and the different "tasks" will append the package name for example

join(DIST_ROOT, 'packages', 'material')

[devversion]

@jelbourn Done. Just renamed the file to build-config.ts.

[jelbourn]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}