Skip to content

build: suppress logging of sauce-connect #4856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2017
Merged

build: suppress logging of sauce-connect #4856

merged 1 commit into from
May 30, 2017

Conversation

devversion
Copy link
Member

  • Suppresses normal log messages from Saucelabs Conect. Error messages will still show up
  • No longer suppresses the whole Browserstack Tunnel execution. Stderr output will be printed if present.
  • Switches to best-practice variable referencing in Bash

Note: In a follow-up PR the normal stdout will be printed together with the stdout on CI failures (finally using the $LOG_DIR variable in the CI)

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 28, 2017
@devversion devversion force-pushed the build/suppress-saucelabs-log branch from 4685f50 to ebc8d19 Compare May 28, 2017 20:25
@devversion
build: suppress logging of sauce-connect
b7efe49 
* Suppresses normal log messages from Saucelabs Conect. Error messages will still show up (In a follow-up PR the normal stdout will be printed together with the stdout on CI failures)
* No longer suppresses the whole Browserstack Tunnel execution. Stderr output will be printed if present. (In a follow-up stdout will be printed as well on CI failures)
* Switches to best-practice variable referencing in Bash
@devversion devversion force-pushed the build/suppress-saucelabs-log branch from ebc8d19 to b7efe49 Compare May 28, 2017 20:32
@devversion devversion requested a review from jelbourn May 29, 2017 20:04
jelbourn
jelbourn approved these changes May 30, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 30, 2017
@mmalerba mmalerba merged commit a681438 into angular:master May 30, 2017
@devversion devversion deleted the build/suppress-saucelabs-log branch November 11, 2017 10:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @mmalerba