build: run fewer browsers on saucelabs #5045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
changed the title
jelbourn
reviewed
Jun 9, 2017
There was a problem hiding this comment.
For a follow-up PR, it would probably be better to run Firefox and Chrome tests directly on Travis rather than going to either service (https://docs.travis-ci.com/user/gui-and-headless-browsers/#Using-the-Chrome-addon-in-the-headless-mode)
test/browser-providers.js
Outdated
| 'Safari9': { unitTest: {target: 'BS', required: false }}, | ||
| 'Safari10': { unitTest: {target: 'SL', required: false }}, | ||
| 'Safari9': { unitTest: {target: null, required: false }}, | ||
| 'Safari10': { unitTest: {target: null, required: false }}, |
There was a problem hiding this comment.
We should be running Safari 9 and 10; I didn't realize these were not marked as required
There was a problem hiding this comment.
Done. Please take another look.
devversion
force-pushed
the
build/less-browsers-saucelabs
branch
4 times, most recently
from
8bda40a to
b8f3591
Compare
* Better balance between Saucelabs and Browserstack because Browserstack runs more stable. Considering that e2e tests also run on Saucelabs it's fair running more on Browserstack.
devversion
force-pushed
the
build/less-browsers-saucelabs
branch
from
b8f3591 to
f8fa5d6
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null. Just to have a nice overview which browsers are running or not.