Skip to content

refactor(chips): replace disabled property with mixin #5072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2017
Merged

refactor(chips): replace disabled property with mixin #5072

merged 1 commit into from
Jun 12, 2017

Conversation

devversion
Copy link
Member

  • Replaces the disabled getter/setter with the mixin for the disabled property.
  • Adds a test for aria-disabled since there was no test for this.

@devversion
refactor(chips): replace disabled property with mixin
623b8e2 
* Replaces the disabled getter/setter with the mixin for the `disabled` property.
* Adds a test for aria-disabled since there was no test for this.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 11, 2017
jelbourn
jelbourn approved these changes Jun 12, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 12, 2017
@kara kara merged commit 90e6d3c into angular:master Jun 12, 2017
@devversion devversion deleted the refactor/chips-use-disabled-mixin branch November 11, 2017 10:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @jelbourn @kara @googlebot @tinayuangao