build: enable noUnusedParameters check #5091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/enable-no-unused-params-check
branch
from
6e65bbb to
976aa40
Compare
* This enables the "noUnusedParameters" TypeScript option in all tsconfig files. This ensures that every package that will be published can be used together with "noUnusedParameters". * Added the "noUnusedParameters" option in unrelated tsconfig files as well (gulp tsconfig). This also helps avoiding unused / unnecessary code. * Skipped setting "noUnusedParameters" for the e2e and prerender project because those are served in AOT mode and the current Angular version of the project does not support "noUnusedParameters" yet.
devversion
force-pushed
the
build/enable-no-unused-params-check
branch
from
976aa40 to
cc32405
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jelbourn I initially was against adding it to the tsconfig files because I expected issues with the livereloading (when serving the app) but I tested it and it works fine like that.
Note: I thought about having a global tsconfig that will be extended by all other child tsconfig files. But this would mean that we need another tsconfig (again). Maybe a longer discussion for the future.