Skip to content

build: separate payload diffs for packages #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

devversion
Copy link
Member

  • Now shows separate payload github statuses for the CDK and Material.
  • No longer shows the Github status if the difference equals zero.
  • Now shows errors if something fails within the Github request (in the functions)
  • Better message for statuses (including full-size of the given package)

Note: The extra check for the packageDiff === 0 is intentionally separate. There should be a different message if the packageDiff is a "valid" but zero.

* Now shows separate payload github statuses for the CDK and Material.
* No longer shows the Github status if the difference equals zero.
* Now shows errors if something fails within the Github request (in the functions)
* Better message for statuses (including full-size of the given package)
@devversion devversion requested a review from jelbourn June 13, 2017 10:55
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 13, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 13, 2017
@kara kara merged commit 46edae6 into angular:master Jun 13, 2017
@devversion devversion deleted the build/separate-payloads branch November 11, 2017 10:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants