test(menu): fix test failures against Angular 4.2

[crisbeto]

Fixes a couple of menu unit tests that were failing against Angular 4.2.2.

[jelbourn]

I was also investigating this now. Determining whether or not the root of this issue needs to be reverted in Angular core.

[crisbeto]

This seems to be the only place where it was happening, though. Perhaps we weren't doing it properly to begin with?

[jelbourn]

I'm starting to think it's a bug because we import NoopAnimationModule and Angular's delegation to the animation driver for removal is not removing the element. Stepping through the animation code now.

[jelbourn]

I suspect
https://github.com/angular/angular/blob/6ca46929fa26468f179196979b5f77a48f79991f/packages/animations/browser/src/render/transition_animation_engine.ts#L299-L299

[alexw10]

Any update on this / on the path forward?

[jelbourn]

LGTM

I sat down and looked at this with Matias and the conclusion was that it only worked by coincidence before 4.2 and that it should have always been doing this

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}