refactor(button, chips): use toString method for aria-disabled #5278
Conversation
For buttons and chips the value of the aria-disabled host binding is resolved from a extra method on the class instance. As already done in other components, the button and chips should just use `boolean.toString()` which is less payload and also makes the code more readable.
googlebot
added
the
cla: yes
| @@ -193,7 +193,7 @@ export class MdButton extends _MdButtonMixinBase implements OnDestroy, CanDisabl | |||
| a[mat-button], a[mat-raised-button], a[mat-icon-button], a[mat-fab], a[mat-mini-fab]`, | |||
| host: { | |||
| '[attr.disabled]': 'disabled || null', | |||
| '[attr.aria-disabled]': '_isAriaDisabled', | |||
| '[attr.aria-disabled]': 'disabled.toString()', | |||
There was a problem hiding this comment.
If we're going shorter, could also do disabled + ''
There was a problem hiding this comment.
Hmm not sure about that. toString() explains what it does and is also pretty short.
There was a problem hiding this comment.
+ '' is pretty idiomatic javascript imo
There was a problem hiding this comment.
Yeah totally. I think it just depends, it's kinda weird doing this in a host binding while we would need to escape the quote (or use the double quote)
I personally prefer toString() as it's describing what it does and is also consistent with all other aria-disabled host bindings.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
For buttons and chips the value of the aria-disabled host binding is resolved from an extra method on the class instance.
As already done in other components, the button and chips should just use
boolean.toString()which is less payload and also makes the code more readable.