-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore(script): automatic example module creation #5350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
3aea6d0
fc161b9
db5bb3c
0402a94
0c8c556
84fa0c8
53744ce
4cd5bc8
4fc9e80
f1ffc60
75a0544
07abc36
f44ba62
98d0c09
6f0cea5
09f7cd8
594165d
73a8655
5295602
adbcd67
f6cf4e7
0066761
4f48592
ed4370d
95aa5f5
926c858
e6200e2
f36c3a5
f4b07f6
de30ac0
89a81b2
e84e920
94ce946
12fda67
35b5690
60f939a
ff508a6
b211611
196b615
eb47447
753a759
c996134
3a2c93b
1f409b6
7ce8853
3926972
3ab9196
c9ac5e5
78f19a4
6a830bc
d6fa609
0f6ea78
ed11e4f
5f50fbf
9832520
a14064c
7740c9a
747e22a
1bdeeca
e24a7da
b495631
f8ef901
e5b16dc
c5743ae
91e03f6
8bb4aff
e57b59a
2610b72
27599e0
40f95ca
63f2511
cd04a67
1e0ae1a
83cdb93
48356de
8c2bb63
2b8cdcc
2fcf5b3
c628047
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
import {Component} from '@angular/core'; | ||
|
||
|
||
/** | ||
* @title Basic buttons | ||
* @id button-overview | ||
* @component ButtonOverviewExample | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remind me why we can't extract the component name from the source? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I first tried |
||
*/ | ||
@Component({ | ||
selector: 'button-overview-example', | ||
templateUrl: 'button-overview-example.html', | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,14 @@ | ||
import {Component} from '@angular/core'; | ||
import {MdDialog} from '@angular/material'; | ||
|
||
|
||
/** | ||
* @title Dialog elements | ||
* @id dialog-elements | ||
* @component DialogElementsExample | ||
* @addlComponents DialogElementsExampleDialog | ||
* @additionalFiles dialog-elements-example-dialog.html | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we not detect additional files at the script level? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ya, using something like a TypeScript parser we could detect these. |
||
* @selectorName DialogElementsExample, DialogElementsExampleDialog | ||
*/ | ||
@Component({ | ||
selector: 'dialog-elements-example', | ||
templateUrl: 'dialog-elements-example.html', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use the directory name (minus the
-example
) part) as the ID for each example? One less thing to manually keep consistent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, sounds like a good idea. Just a hold over from previous code.