Skip to content

fix(github docs): Includes @angular/cdk in installation instructions #5555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2017
Merged

fix(github docs): Includes @angular/cdk in installation instructions #5555

merged 4 commits into from
Jul 7, 2017

Conversation

julianobrasil
Copy link
Contributor

Includes @angular/cdk in installation instructions.

Closes #5552.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jul 6, 2017
@julianobrasil
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jul 6, 2017
Add the latest builds instructions in the installation section (Step 1).
The Getting Started section has all the information necessary to proceed with installations: #5552 (comment)
@julianobrasil
Copy link
Contributor Author

Just updated this PR as said in #5552 (comment)

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 7, 2017
@mmalerba mmalerba merged commit eedf36c into angular:master Jul 7, 2017
amcdnl pushed a commit to amcdnl/material2 that referenced this pull request Jul 8, 2017
…ngular#5555)

* includes @angular/cdk in github material installation instructions

* Mention the latest builds instructions

Add the latest builds instructions in the installation section (Step 1).

* Delete the installation section

The Getting Started section has all the information necessary to proceed with installations: angular#5552 (comment)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(github docs): mention @angular/cdk in material installation instructions
4 participants