bug(button): properly align text in fab buttons #5632 #5634
Conversation
googlebot
added
the
cla: yes
| @@ -107,7 +107,7 @@ | |||
| } | |||
|
|
|||
| @mixin mat-button-typography($config) { | |||
| .mat-button, .mat-raised-button, .mat-icon-button { | |||
| .mat-button, .mat-raised-button, .mat-icon-button, .mat-fab, .mat-mini-fab { | |||
There was a problem hiding this comment.
@crisbeto did you have a reason for omitting the fab buttons here?
There was a problem hiding this comment.
I don't remember, but it was probably because the fabs aren't really meant to be used with text.
There was a problem hiding this comment.
@crisbeto Is there any reason why not to?
There was a problem hiding this comment.
The spec doesn't really have fabs with text, if I remember correctly, but it shouldn't be an issue to keep it anyway.
There was a problem hiding this comment.
@crisbeto We good to merge then?
jelbourn
added
pr: lgtm
action: merge
|
Caretaker note: let me know if this causes any screenshot diffs |
|
@jelbourn No screenshot diff failures, so merging. |
kara
removed
the
merge: caretaker note
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Addresses: Link Fab Buttons incorrect line height #5632
BEFORE
AFTER
