Skip to content

chore: remove drag event from gestures demo #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2017
Merged

chore: remove drag event from gestures demo #6032

merged 1 commit into from
Jul 27, 2017

Conversation

devversion
Copy link
Member

  • The custom recognizer called "drag" has been removed a long time (fix(gestures): remove drag event from config #1744) ago to avoid collisions with the native drag events.
  • The demo app still shows the drag event on the gestures demo (which apparently doesn't work now anymore)

@devversion
chore: remove drag event from gestures demo
ba74ef8 
* The custom recognizer called "drag" has been removed a long time ago to avoid collisions with the native `drag` events.
* The demo app still shows the drag event on the gestures demo (which apparently doesn't work now anymore)
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 25, 2017
jelbourn
jelbourn approved these changes Jul 25, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 25, 2017
@andrewseguin andrewseguin merged commit 0f1d319 into angular:master Jul 27, 2017
@devversion devversion deleted the chore/remove-drag-demo branch September 27, 2017 14:46
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @andrewseguin