Skip to content

build: dynamic cdk entrypoint mapping in tsconfigs #6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2017
Merged

build: dynamic cdk entrypoint mapping in tsconfigs #6088

merged 1 commit into from
Jul 27, 2017

Conversation

devversion
Copy link
Member

  • Removes the hard-coded path mappings for the CDK entry points and replaces it with a dynamic solution.
  • The tsconfig-test.json extends the path mappings from the normal build tsconfig.

@devversion
build: dynamic cdk entrypoint mapping in tsconfigs
03e3e14 
* Removes the hard-coded path mappings for the CDK entry points and replaces it with a dynamic solution.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 27, 2017
jelbourn
jelbourn approved these changes Jul 27, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 27, 2017
@andrewseguin andrewseguin merged commit 072b32a into angular:master Jul 27, 2017
@devversion devversion deleted the build/dynamic-cdk-mappings branch November 11, 2017 10:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @andrewseguin