Skip to content

build: no longer add pure annotations to es5 bundles #6107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Jul 28, 2017

  • The pure annotations are no longer added to ES5 bundles of Angular Material or the CDK. The pure annotations should be added by the new build optimizer which is part of the CLI.

@devversion devversion requested a review from jelbourn as a code owner July 28, 2017 12:01
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 28, 2017
@jelbourn
Copy link
Member

@kara mentioned we might not want to actually being doing this.

@jelbourn jelbourn assigned kara and unassigned jelbourn Jul 28, 2017
@jelbourn jelbourn requested a review from kara July 28, 2017 16:40
@devversion
Copy link
Member Author

@jelbourn Ah I guess because of the new optimizer stuff. In this case we either need to remove it or just add it to all bundles.

@devversion devversion force-pushed the build/pure-annotations-secondaries branch 3 times, most recently from 2a91f77 to 7bcb300 Compare August 1, 2017 16:24
* The pure annotations are no longer added to ES5 bundles of Angular Material or the CDK. The pure annotations should be added by the new build optimizer which is part of the CLI.
@devversion devversion force-pushed the build/pure-annotations-secondaries branch from 7bcb300 to f6cd431 Compare August 1, 2017 16:25
@devversion
Copy link
Member Author

devversion commented Aug 1, 2017

Chatted with @kara about this. We agreed that it would make sense to no longer add the pure annotations to our ES5 bundles.

Please review @kara @jelbourn

@devversion devversion changed the title build: add pure annotations to all es5 bundles build: no longer add pure annotations to es5 bundles Aug 1, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 1, 2017
@tinayuangao tinayuangao merged commit 2320532 into angular:master Aug 1, 2017
@devversion devversion deleted the build/pure-annotations-secondaries branch November 11, 2017 10:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants