-
Notifications
You must be signed in to change notification settings - Fork 6.8k
a11y(toolbar): Add toolbar accessibility demo page #6145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
deb00b5
a11y(checkbox): Add toolbar accessibility demo page #6121
amcdnl a9fbcd9
chore(*): tweaks to the demos
amcdnl 8a5ccb4
Merge branch 'master' into a11y-toolbar
amcdnl 803199a
chore(*): update per pr feedback
amcdnl 6badc04
Merge branch 'master' into a11y-toolbar
amcdnl b670e5c
chore(nit): rearrange import
amcdnl 041646f
chore(*): adding toolbar content
amcdnl f836a03
a11y(toolbar): nit
amcdnl bb7fe42
Merge branch 'master' into a11y-toolbar
amcdnl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<div class="demo-toolbar"> | ||
<section> | ||
<h2>Basic Toolbar with Text (e.g. Only display app’s name)</h2> | ||
<md-toolbar role="heading"> | ||
<h1>My App</h1> | ||
</md-toolbar> | ||
<p>Hello World!</p> | ||
</section> | ||
|
||
<section> | ||
<h2>Multiple Lines Toolbar</h2> | ||
<md-toolbar> | ||
<h1>Settings</h1> | ||
</md-toolbar> | ||
<md-toolbar> | ||
<h1>Profile</h1> | ||
</md-toolbar> | ||
<p>My profile</p> | ||
</section> | ||
|
||
<section> | ||
<h2>Toolbar with favorite icon</h2> | ||
<md-toolbar> | ||
<h1>My App</h1> | ||
<span class="example-spacer"></span> | ||
<button md-button> | ||
<md-icon aria-label="favorite">favorite</md-icon> | ||
</button> | ||
</md-toolbar> | ||
<p>Hello World!</p> | ||
</section> | ||
|
||
<section> | ||
<h2>Toolbar colors</h2> | ||
<md-toolbar color="primary"> | ||
<h1>My App</h1> | ||
</md-toolbar> | ||
<p>Hello World!</p> | ||
</section> | ||
</div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
.demo-button { | ||
button, a { | ||
margin: 8px; | ||
text-transform: uppercase; | ||
} | ||
|
||
section { | ||
display: flex; | ||
align-items: center; | ||
margin: 8px; | ||
} | ||
|
||
p { | ||
padding: 5px 15px; | ||
} | ||
} | ||
|
||
.example-spacer { | ||
flex: 1 1 auto; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import {Component} from '@angular/core'; | ||
|
||
|
||
@Component({ | ||
moduleId: module.id, | ||
selector: 'toolbar-a11y', | ||
templateUrl: 'toolbar-a11y.html', | ||
styleUrls: ['toolbar-a11y.css'], | ||
}) | ||
export class ToolbarAccessibilityDemo { | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't very clear in the last comments: each toolbar should have some actual content under it as well (that the toolbar describes; can just be a
<p>
)