fix(tooltip): exception if mdTooltip is not a string

[rafaelss95]

Fixes an error that is thrown if something rather than a string is passed via [mdTooltip] @Input, i.e:

@Component({
  selector: 'some-selector',
  template: '<div [mdTooltip]="myNumber">Content</div>'
})
export class SomeClass {
  
  myNumber = 3;
}

Results in the following error:

this._message.trim is not a function

PLUNKER

[crisbeto]

Can you add a unit test for this? It should look something along the lines of this:

it('should not throw when a truthy non-string is passed in', () => {
  tooltipDirective.message = {};

  expect(() => {
    fixture.detectChanges();
    tooltipDirective.show();    
  }).not.toThrow();
});

[rafaelss95]

@crisbeto I can't do this. It gives me error (the method signature asks for a string):

Type '{}' is not assignable to type 'string'.

[crisbeto]

Since it's only a test component, you can change the property signature to any.

[rafaelss95]

I'm not sure I follow what you mean. tooltipDirective is an instance of MdTooltip and there the signature of set message(..) accepts (only) a string:

 set message(value: string) {
   this._message = value;
   this._setTooltipMessage(this._message);
 }

[crisbeto]

I was talking about one of the test components here: https://github.com/angular/material2/blob/master/src/lib/tooltip/tooltip.spec.ts#L523

[rafaelss95]

Changing message from string to any (in BasicTooltipDemo component) still fail.

[rafaelss95]

Closing due to #7018 and #7024. Btw, the PRs doesn't have any tests as well...

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}