Skip to content

build: stop hardcoding rollup globals for CDK entry points #6150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2017
Merged

build: stop hardcoding rollup globals for CDK entry points #6150

merged 1 commit into from
Aug 2, 2017

Conversation

devversion
Copy link
Member

  • Now the rollup globals for the CDK secondary entry-points are no longer hard-coded. There is already a method called getSecondaryEntryPointsForPackage which can be used.

@devversion devversion requested a review from jelbourn as a code owner July 30, 2017 10:45
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2017
jelbourn
jelbourn approved these changes Jul 31, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though this will conflict w/ Kristiyan's PR to move the globals into their own files

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 31, 2017
@devversion
build: stop hardcoding rollup globals for CDK entry points
a4424fb 
* Now the rollup globals for the CDK secondary entry-points are no longer hard-coded. There is already a method called `getSecondaryEntryPointsForPackage` which can be used.
@devversion devversion force-pushed the build/dynamic-rollup-globals-entries branch from bf99c6b to a4424fb Compare August 2, 2017 10:19
@tinayuangao tinayuangao merged commit 4168fb3 into angular:master Aug 2, 2017
@devversion devversion deleted the build/dynamic-rollup-globals-entries branch November 11, 2017 10:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @tinayuangao