Skip to content

Add complex tabs example #6295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2017
Merged

Add complex tabs example #6295

merged 3 commits into from
Sep 8, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Aug 5, 2017

Replaces the 'Coming Soon!' example with an advanced tab example showing:

  • Different content sizes
  • Tab HTML Labels
  • Disabled Tabs
  • Tab Header Overflow

@amcdnl amcdnl requested a review from jelbourn August 5, 2017 17:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 5, 2017
@jelbourn jelbourn requested a review from andrewseguin August 16, 2017 22:30
@amcdnl
Copy link
Contributor Author

amcdnl commented Sep 4, 2017

@jelbourn - can this be merged?

jelbourn
jelbourn approved these changes Sep 7, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 7, 2017
@tinayuangao tinayuangao merged commit dd37acf into angular:master Sep 8, 2017
@amcdnl amcdnl deleted the demo-tabs branch September 9, 2017 14:48
@amcdnl amcdnl mentioned this pull request Oct 3, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amcdnl @jelbourn @googlebot @tinayuangao @andrewseguin