-
Notifications
You must be signed in to change notification settings - Fork 6.8k
demo(icon): Add an accessibility demo page for icon #6348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,14 @@ | |||
<section> | |||
<h2>Home icon (Ligature from Material Icons font)</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have examples for each of the accessibility use cases listed here: https://material.angular.io/components/icon/overview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Changed to uses cases listed in https://material.angular.io/components/icon/overview
@@ -0,0 +1,17 @@ | |||
<section> | |||
<h2>Fingerprint icon (Decorative icons)</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this something like
<h2>Fingerprint status</h2>
<p>Showing a status message with a purely decorative icon</p>
<md-icon color="primary">fingerprint</md-icon>
Your fingerprint was recorded!
(similar structure for other examples)
<h2>Delete icon (Interactive icons) </h2> | ||
<button md-icon-button aria-label="Delete" (click)="deleteIcon()"> | ||
<md-icon color="accent">delete</md-icon> | ||
</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have an example with <a md-icon-button>
as well
Added another example with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.