refactor(autocomplete): make keyboard and visibility calls synchronous #6441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
reviewed
Aug 16, 2017
|
|
||
| // Defer emitting to the stream until the next tick, because changing | ||
| // bindings in here will cause "changed after checked" errors. | ||
| return Promise.resolve(); |
There was a problem hiding this comment.
Mixing switchMap and Promise.resolve doesn't feel quite right. Use do and observeOn(asap) operators here instead? It would be more rx idiomatic.
crisbeto
force-pushed
the
autocomplete-promise-refactor
branch
2 times, most recently
from
5da9ee7 to
de700f1
Compare
|
@kara I've switch it to use |
crisbeto
force-pushed
the
autocomplete-promise-refactor
branch
from
de700f1 to
0d94a6b
Compare
crisbeto
force-pushed
the
autocomplete-promise-refactor
branch
from
0d94a6b to
02bbe0e
Compare
crisbeto
added
the
P1
crisbeto
force-pushed
the
autocomplete-promise-refactor
branch
from
02bbe0e to
e0ea08e
Compare
crisbeto
added
action: merge
crisbeto
force-pushed
the
autocomplete-promise-refactor
branch
2 times, most recently
from
fa2f980 to
37a0d19
Compare
|
@crisbeto Looks like a linter failure bc map is unused. Update? |
crisbeto
force-pushed
the
autocomplete-promise-refactor
branch
from
37a0d19 to
f13b84e
Compare
|
Fixed the linting error and a test failure. |
crisbeto
added
action: merge
Reworks a few methods, that were changing the view in a `Promise.resolve`, to be synchronous. The initial idea behind deferring those calls was to avoid "changed after checked" errors, however they also make things harder to test. It seems like the root of the issue for all of them was that we were trying to modify view properties after the `options.changed` callback had fired, which comes after change detection. These changes have the advantage of making things a lot easier and cleaner to test, as well as making the API easier to use.
crisbeto
force-pushed
the
autocomplete-promise-refactor
branch
from
f13b84e to
ff41770
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks a few methods, that were changing the view in a
Promise.resolve, to be synchronous. The initial idea behind deferring those calls was to avoid "changed after checked" errors, however they also make things harder to test. It seems like the root of the issue for all of them was that we were trying to modify view properties after theoptions.changedcallback had fired, which comes after change detection. These changes have the advantage of making things a lot easier and cleaner to test, as well as making the API easier to use.