-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(customizing): add guide for overriding styles #6541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Just one small addition
the styles you write will affect all the elements in your component template. They will *not* | ||
affect elements that are children of other components within your template. You can read more | ||
about view encapsulation in the | ||
[Angular documentation](https://angular.io/guide/component-styles#view-encapsulation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to include a link to the recent blog post on this subject as well: https://blog.angular.io/the-state-of-css-in-angular-4a52d4bd2700
(which was partially ghostwritten by me)
Done! Thank you and Stephen for putting that post together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a typo. Should be a quick fix
|
||
##### Component location | ||
|
||
Some Angular Material components, specifically overlay-based ones like MdDialog, MdSnakcbar, etc., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: MdSnakcbar
-> MdSnackbar
@willshowell Thanks for the quick fix! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #6087