Skip to content

docs(customizing): add guide for overriding styles #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2017

Conversation

willshowell
Copy link
Contributor

Fixes #6087

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 18, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Just one small addition

the styles you write will affect all the elements in your component template. They will *not*
affect elements that are children of other components within your template. You can read more
about view encapsulation in the
[Angular documentation](https://angular.io/guide/component-styles#view-encapsulation).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to include a link to the recent blog post on this subject as well: https://blog.angular.io/the-state-of-css-in-angular-4a52d4bd2700
(which was partially ghostwritten by me)

@willshowell
Copy link
Contributor Author

Done! Thank you and Stephen for putting that post together

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added docs This issue is related to documentation pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 18, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo. Should be a quick fix


##### Component location

Some Angular Material components, specifically overlay-based ones like MdDialog, MdSnakcbar, etc.,
Copy link
Contributor

@kara kara Aug 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: MdSnakcbar -> MdSnackbar

@kara kara removed the action: merge The PR is ready for merge by the caretaker label Aug 21, 2017
@kara kara added the action: merge The PR is ready for merge by the caretaker label Aug 21, 2017
@kara
Copy link
Contributor

kara commented Aug 21, 2017

@willshowell Thanks for the quick fix!

@kara kara merged commit c86d13c into angular:master Aug 21, 2017
@willshowell willshowell deleted the guide/customizing-styles branch August 21, 2017 19:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] guide for customizing material component styles
4 participants