chore(e2e): fix consistent timeouts #6574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
force-pushed
the
e2e-hang
branch
2 times, most recently
from
99a9177 to
f1e780a
Compare
jelbourn
requested review from
crisbeto and
tinayuangao
and removed request for
devversion
jelbourn
added
pr: needs review
and removed
in progress
|
Ready for review. Being perfectly honest, I'm not 100% sure why this fixes the issue. My theory is that adding the extra |
kara
added
pr: lgtm
action: merge
crisbeto
approved these changes
Aug 22, 2017
| return downloadGoldScreenshotFiles(database); | ||
| }) | ||
| .then(() => { | ||
| console.log(` Downloading golds done (took ${Date.now() - lastActionTime}ms)`); |
There was a problem hiding this comment.
If you want these to be formatted better, you can import {log} from 'gulp-util'.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.