build: stricter unused variable checking #6633
Conversation
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn,
josephperrott and
kara
as code owners
googlebot
added
the
cla: yes
src/lib/paginator/paginator.spec.ts
Outdated
| @@ -281,7 +281,7 @@ class MdPaginatorApp { | |||
|
|
|||
| @ViewChild(MdPaginator) mdPaginator: MdPaginator; | |||
|
|
|||
| constructor(private _elementRef: ElementRef) { } | |||
| constructor() {} | |||
There was a problem hiding this comment.
You can remove this constructor.
Currently only variables that don't start with an underscore will be checked by TSLint. This doesn't make sense, because variables get prefixed with an underscore to indicate that they are not part of the public API, but still need to be public in favor of AOT compilation for example. This means that those properties are having the public modifier set (explicitly or automatically) and therefore won't be treated as unused anyway. **TL;DR**: With this change, prefixed variables will be checked by the `no-unused-variable` TSLint rule and those which are marked as `private` and are unused will be catched by TSLint.
devversion
force-pushed
the
build/stricter-no-unused-variable
branch
from
a534d55 to
775b0f8
Compare
| @@ -89,6 +89,7 @@ export class StartWithBrand { private _; } | |||
| export class DebounceTimeBrand { private _; } | |||
| export class AuditTimeBrand { private _; } | |||
| export class TakeUntilBrand { private _; } | |||
There was a problem hiding this comment.
I'd be ok with having these properties be public. They're not a part of any API or generated JS anyway.
There was a problem hiding this comment.
Yeah I don't mind either. I just changed it
Edit: Actually it looks like making the property public causes TypeScript to complain.
There was a problem hiding this comment.
The brand properties actually must be private, otherwise they are structurally identical to each other
devversion
force-pushed
the
build/stricter-no-unused-variable
branch
from
336b331 to
775b0f8
Compare
jelbourn
added
P4
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently only variables that don't start with an underscore will be checked by TSLint.
This doesn't make sense, because variables get prefixed with an underscore to indicate that they are not part of the public API, but still need to be public in favor of AOT compilation for example. This means that those properties are having the public modifier set (explicitly or automatically) and therefore won't be treated as unused anyway.
TL;DR: With this change, prefixed variables will be checked by the
no-unused-variableTSLint rule and those which are marked asprivateand are unused will be catched by TSLint.