Skip to content

chore: bump version to beta.9 w/ changelog #6705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Conversation

jelbourn
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 29, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos

CHANGELOG.md Outdated
* Nested menus
* Autocomplete supports `md-optgroup`
* `Overlay` moved to `@angular/cdk`
* New `MdSelectionList`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: New component MdSelectionList ?

CHANGELOG.md Outdated

### Breaking changes
* Imports from `@angular/cdk` are now scoped to a specific sub-package. For example, if you
previous had:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: previous -> previously

CHANGELOG.md Outdated
```ts
import {LiveAnnouncer, Overlay, Directionality} from '@angular/cdk';
```
You would will now need to write:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: would will now -> will now

CHANGELOG.md Outdated
```

This helps ensure you're only pulling in the pieces of the cdk being used as well as providing more
context about what an imported symbol is be used for.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: is be used for -> is being used for

or formControl).
* **datepicker:** `NativeDateAdapter` will now use Angular's LOCALE_ID instead of the browser's
locale.
* **sidenav:** CSS classes have changed from `mat-sidenav-` to `mat-drawer-`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: CSS class prefixes ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider the "prefix" to just be "md"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget about mdDatepickerToggle (looking for the thread now)

CHANGELOG.md Outdated
* `md-input-container` has been renamed to `md-form-field`. The old selector will be removed in a
subsequent release. This is in preparation to making `md-select` a child of `md-form-field`
such that both select and input share the same features and appearance.
* For camcelCased directives, each corresponding `@Input()` is now also prefixed. For example,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: camcelCased -> camelCased

@jelbourn
Copy link
Member Author

@kara fixed typos

@josephperrott josephperrott self-requested a review August 29, 2017 22:32
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 29, 2017
@jelbourn jelbourn merged commit 13fb5b4 into angular:master Aug 29, 2017
@jelbourn jelbourn deleted the beta9 branch April 2, 2018 22:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants