-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: bump version to beta.9 w/ changelog #6705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typos
CHANGELOG.md
Outdated
* Nested menus | ||
* Autocomplete supports `md-optgroup` | ||
* `Overlay` moved to `@angular/cdk` | ||
* New `MdSelectionList` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: New component MdSelectionList
?
CHANGELOG.md
Outdated
|
||
### Breaking changes | ||
* Imports from `@angular/cdk` are now scoped to a specific sub-package. For example, if you | ||
previous had: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: previous -> previously
CHANGELOG.md
Outdated
```ts | ||
import {LiveAnnouncer, Overlay, Directionality} from '@angular/cdk'; | ||
``` | ||
You would will now need to write: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: would will now -> will now
CHANGELOG.md
Outdated
``` | ||
|
||
This helps ensure you're only pulling in the pieces of the cdk being used as well as providing more | ||
context about what an imported symbol is be used for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: is be used for -> is being used for
or formControl). | ||
* **datepicker:** `NativeDateAdapter` will now use Angular's LOCALE_ID instead of the browser's | ||
locale. | ||
* **sidenav:** CSS classes have changed from `mat-sidenav-` to `mat-drawer-` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: CSS class prefixes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I consider the "prefix" to just be "md"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget about mdDatepickerToggle
(looking for the thread now)
CHANGELOG.md
Outdated
* `md-input-container` has been renamed to `md-form-field`. The old selector will be removed in a | ||
subsequent release. This is in preparation to making `md-select` a child of `md-form-field` | ||
such that both select and input share the same features and appearance. | ||
* For camcelCased directives, each corresponding `@Input()` is now also prefixed. For example, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: camcelCased -> camelCased
@kara fixed typos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.