chore(docs): create missing markdown files for cdk items #6770
Conversation
josephperrott
requested review from
andrewseguin,
crisbeto,
devversion and
jelbourn
as code owners
googlebot
added
the
cla: yes
src/cdk/keycodes/keycodes.md
Outdated
| arrowPressCount = 0; | ||
|
|
||
| handleKeyPress(event: KeyboardEvent) { | ||
| if (event.codeCode in [UP_ARROW, DOWN_ARROW, LEFT_ARROW, RIGHT_ARROW]) { |
There was a problem hiding this comment.
event.codeCode->event.keyCode.- This check will look for a property that corresponds to
event.keyCodein theArrayprototype. The correct way to check it is[UP_ARROW, DOWN_ARROW, LEFT_ARROW, RIGHT_ARROW].includes(event.keyCode).
src/cdk/overlay/overlay.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| ### Overlay | |||
|
|
|||
| A component used to manage overlays. | |||
There was a problem hiding this comment.
Overlay is a service, not a component.
src/cdk/rxjs/rxjs.md
Outdated
| @@ -0,0 +1,36 @@ | |||
| ### RxJS Usage | |||
| When dealing with RxJS operators, it is best to import the operator functions directly (e.g. | |||
There was a problem hiding this comment.
This should mention that avoiding the patch operators is only recommended when writing a library.
src/cdk/rxjs/rxjs.md
Outdated
| ``` | ||
|
|
||
| #### Available Operators | ||
| Many operators are provided in via the `RxChain`, these operators include: |
There was a problem hiding this comment.
I don't think that we should include the list operators here, because it means that we'll have to maintain it.
There was a problem hiding this comment.
Yeah, you're right. I went back and forth on it before I put it in.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.