Skip to content

fix(drawer): unable to toggle while drawer is animating #6810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 2, 2017

Fixes not being able to toggle a drawer while it is mid-animation.

Fixes #6376.
Fixes #6985.

@crisbeto crisbeto requested a review from mmalerba as a code owner September 2, 2017 13:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 2, 2017
@kara
Copy link
Contributor

kara commented Oct 5, 2017

@crisbeto Rebase?

@kara kara added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Oct 5, 2017
@kara kara assigned crisbeto and unassigned mmalerba Oct 5, 2017
Fixes not being able to toggle a drawer while it is mid-animation.

Fixes angular#6376.
@crisbeto crisbeto force-pushed the 6376/sidenav-animation-guard branch from 1695e74 to f3d7a67 Compare October 5, 2017 16:52
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Oct 5, 2017
@crisbeto
Copy link
Member Author

crisbeto commented Oct 5, 2017

Rebased.

@kara kara merged commit 085827f into angular:master Oct 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SideNav [opened] property bound not working correctly when bound to an observable [sidenav] can't close until opening animation is complete
4 participants