build: custom tslint rules not executing in IDEs #6817
Conversation
googlebot
added
the
cla: yes
| @@ -35,23 +35,23 @@ class Walker extends Lint.RuleWalker { | |||
| this._enabled = fileGlobs.some(p => minimatch(relativeFilePath, p)); | |||
| } | |||
|
|
|||
| visitClassDeclaration(node) { | |||
| visitClassDeclaration(node: any) { | |||
There was a problem hiding this comment.
Don't you want to use types here? e.g ts.ClassDeclaration? (also below)
There was a problem hiding this comment.
I can definitely use it for the node, but the expression below doesn't seem to be in the typings.
There was a problem hiding this comment.
Not really something that is too important. For the expression you could use ts.CallExpression, but it will not have types for the arguments[0].properties.
There was a problem hiding this comment.
Yeah eventually the arguments have to be cast to any.
Fixes our custom tslint rules not executing IDEs, because they're written in TypeScript. This is the preferred option over switching them back to ES6, because some rules require access to TS files from other parts of the build (e.g. the Rollup globals rule).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes our custom tslint rules not executing IDEs, because they're written in TypeScript. This is the preferred option over switching them back to ES6, because some rules require access to TS files from other parts of the build (e.g. the Rollup globals rule).