build: cancel screenshot diff if there is no activity #6957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
the
blocked
jelbourn
approved these changes
Sep 10, 2017
tools/gulp/tasks/screenshots.ts
Outdated
| @@ -34,6 +34,9 @@ const FIREBASE_IMAGE = `${TEMP_FOLDER}/screenshot/images`; | |||
| const FIREBASE_DATA_GOLDENS = `screenshot/goldens`; | |||
| const FIREBASE_STORAGE_GOLDENS = 'goldens'; | |||
|
|
|||
| const lastActionTimeout = 1000 * 60 * 6; | |||
| const lastActionRefreshInterval = 1000 * 45; | |||
There was a problem hiding this comment.
Add comments with the human-readable times?
* No longer just gives the screenshot diff task 8 minutes to pass, because the run time can vary. Now it just exits the process if the last action in the task takes longer than 6 minutes. * Instead of just closing the firebase connection, the process will be exited with an error code. Just closing the connection is not helpful and breaks the screenshot diff Web Interface.
devversion
force-pushed
the
build/fix-e2e-task-screenshot-exit
branch
2 times, most recently
from
3ab54b7 to
e9d90e0
Compare
devversion
force-pushed
the
build/fix-e2e-task-screenshot-exit
branch
from
e9d90e0 to
1f10516
Compare
jelbourn
added
action: merge
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 15, 2017
* build: cancel screenshot diff if there is no activity * No longer just gives the screenshot diff task 8 minutes to pass, because the run time can vary. Now it just exits the process if the last action in the task takes longer than 6 minutes. * Instead of just closing the firebase connection, the process will be exited with an error code. Just closing the connection is not helpful and breaks the screenshot diff Web Interface. * Add comments
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Should wait for #6956 before review.