docs(overlay): expand overview for overlay #6976

jelbourn · 2017-09-10T20:20:11Z

No description provided.

crisbeto · 2017-09-10T20:26:48Z

src/cdk/overlay/overlay.md

+managing that specific overlay.
+
+The `OverlayRef` _is_ a `PortalHost`- once creates, content can be added by attaching a `Portal`.


once creates -> once created

crisbeto · 2017-09-10T20:27:17Z

src/cdk/overlay/overlay.md

+
+The `OverlayRef` _is_ a `PortalHost`- once creates, content can be added by attaching a `Portal`.
+See the documentation on portals for further information.


Link to the portal docs (if we have any)?

They don't exist yet; I'm planning to do a pass and add cross-references once I have more of the content authored

kara

Few typos

kara · 2017-09-11T17:20:04Z

src/cdk/overlay/overlay.md

+`BlockScrollStrategy` will block page scrolling while the overlay is open. Note that some
+applications may implement special or customized page scrolling; if the `BlockScrollStrategy`
+conflicts with this kind of situation, it can overriden by re-providing `BlockScrollStrategy` with


can overridden -> can be overridden

kara · 2017-09-11T17:20:27Z

src/cdk/overlay/overlay.md

+
+`RepositionScrollStrategy` will re-position the overlay element on scroll. Note that this will have
+some performance impact on scrolling- users should weigh this cost in the context each specific


in the context each -> in the context of each

jelbourn

Comments addressed

jelbourn · 2017-09-13T04:47:04Z

src/cdk/overlay/overlay.md

+managing that specific overlay.
+
+The `OverlayRef` _is_ a `PortalHost`- once creates, content can be added by attaching a `Portal`.


jelbourn · 2017-09-13T04:47:38Z

src/cdk/overlay/overlay.md

+
+The `OverlayRef` _is_ a `PortalHost`- once creates, content can be added by attaching a `Portal`.
+See the documentation on portals for further information.


They don't exist yet; I'm planning to do a pass and add cross-references once I have more of the content authored

jelbourn · 2017-09-13T04:47:55Z

src/cdk/overlay/overlay.md

+`BlockScrollStrategy` will block page scrolling while the overlay is open. Note that some
+applications may implement special or customized page scrolling; if the `BlockScrollStrategy`
+conflicts with this kind of situation, it can overriden by re-providing `BlockScrollStrategy` with


jelbourn · 2017-09-13T04:48:07Z

src/cdk/overlay/overlay.md

+
+`RepositionScrollStrategy` will re-position the overlay element on scroll. Note that this will have
+some performance impact on scrolling- users should weigh this cost in the context each specific


willshowell · 2017-09-13T15:13:10Z

src/cdk/overlay/overlay.md

+The `FullscreenOverlayContainer` is an alternative to `OverlayContainer` that supports correct
+displaying of overlay elements in
+[fullscreen mode][https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullScreen].


Link syntax

Whoops, good catch

crisbeto

LGTM, aside from the link syntax error.

angular-automatic-lock-bot · 2019-09-07T04:02:11Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

jelbourn added docs This issue is related to documentation pr: needs review labels Sep 10, 2017

jelbourn requested review from kara and crisbeto September 10, 2017 20:20

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 10, 2017

crisbeto reviewed Sep 10, 2017

View reviewed changes

kara reviewed Sep 11, 2017

View reviewed changes

jelbourn force-pushed the cdk-docs branch from a38ec7a to a9439b1 Compare September 13, 2017 04:48

jelbourn commented Sep 13, 2017

View reviewed changes

willshowell reviewed Sep 13, 2017

View reviewed changes

crisbeto approved these changes Sep 13, 2017

View reviewed changes

crisbeto added pr: lgtm and removed pr: needs review labels Sep 13, 2017

docs(overlay): expand overview for overlay

262dccb

jelbourn force-pushed the cdk-docs branch from a9439b1 to 262dccb Compare September 13, 2017 17:23

jelbourn added action: merge The PR is ready for merge by the caretaker pr: merge safe labels Sep 13, 2017

mmalerba merged commit 5daf7ff into angular:master Sep 14, 2017

josephperrott pushed a commit to josephperrott/components that referenced this pull request Sep 15, 2017

docs(overlay): expand overview for overlay (angular#6976)

2bca47b

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019

		managing that specific overlay.

		The `OverlayRef` _is_ a `PortalHost`- once creates, content can be added by attaching a `Portal`.


		The `OverlayRef` _is_ a `PortalHost`- once creates, content can be added by attaching a `Portal`.
		See the documentation on portals for further information.


		`RepositionScrollStrategy` will re-position the overlay element on scroll. Note that this will have
		some performance impact on scrolling- users should weigh this cost in the context each specific

docs(overlay): expand overview for overlay #6976

docs(overlay): expand overview for overlay #6976

Uh oh!

Conversation

jelbourn commented Sep 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelbourn Sep 13, 2017 • edited by crisbeto Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelbourn Sep 13, 2017 • edited by crisbeto Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crisbeto left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot bot commented Sep 7, 2019

Uh oh!

Uh oh!

jelbourn Sep 13, 2017 •

edited by crisbeto

Loading

jelbourn Sep 13, 2017 •

edited by crisbeto

Loading

crisbeto left a comment •

edited

Loading