Skip to content

docs: add live example of nested menu #6977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

crisbeto
Copy link
Member

Adds a live example for the nested menu functionality.

Fixes #6920.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 10, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this example to menu.md?

@crisbeto crisbeto force-pushed the 6920/nested-menu-example branch from 8a369d4 to 7013547 Compare September 11, 2017 16:55
@crisbeto crisbeto requested a review from kara as a code owner September 11, 2017 16:55
@crisbeto
Copy link
Member Author

Added @jelbourn.

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the style link. Apply merge label when ready.

*/
@Component({
selector: 'nested-menu-example',
templateUrl: 'nested-menu-example.html',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the CSS file here? Otherwise, people might edit later without realizing it's not linked.

@crisbeto crisbeto force-pushed the 6920/nested-menu-example branch from 7013547 to 4495fb0 Compare September 11, 2017 17:22
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 11, 2017
Adds a live example for the nested menu functionality.

Fixes angular#6920.
@crisbeto crisbeto force-pushed the 6920/nested-menu-example branch from 4495fb0 to 2e4b5e5 Compare September 11, 2017 18:36
@mmalerba mmalerba merged commit 2cefe67 into angular:master Sep 12, 2017
@@ -1,6 +1,7 @@
`<md-menu>` is a floating panel containing list of options.

<!-- example(menu-overview) -->
<!-- example(nested-menu) -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add docs for how to nest them and put this under that section.

josephperrott pushed a commit to josephperrott/components that referenced this pull request Sep 15, 2017
Adds a live example for the nested menu functionality.

Fixes angular#6920.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create live-example with nested menu
6 participants