build: round payload size for comparison #7174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/round-payload-size
branch
from
50a8c18 to
7d579fe
Compare
jelbourn
reviewed
Sep 19, 2017
| @@ -93,10 +93,10 @@ async function calculatePayloadDiff(database: firebaseAdmin.database.Database, c | |||
|
|
|||
| // Calculate the payload diffs by subtracting the previous size of the FESM ES2015 bundles. | |||
| const cdkFullSize = currentPayload.cdk_fesm_2015; | |||
| const cdkDiff = cdkFullSize - previousPayload.cdk_fesm_2015; | |||
| const cdkDiff = roundFileSize(cdkFullSize - previousPayload.cdk_fesm_2015); | |||
There was a problem hiding this comment.
It returns a string instead of a number. I don't think re-parsing is better.
There was a problem hiding this comment.
Generally you want to keep your values in number format as long as possible and them format them just before or past of displaying them.
There was a problem hiding this comment.
Yeah that's what this does now. toFixed() returns a string instead of a number. The formatting will happen in the Firebase function.
In some cases the payload is still showing up in the CI even if there was no change to the library. This seems to be because the file sizes are not rounded and can sometimes be not very exact. Resulting in numbers like: `material_fesm_2014": 1004.1319999999998`. To have a better output in the GitHub statuses, the file size should be rounded
devversion
force-pushed
the
build/round-payload-size
branch
from
7d579fe to
4f69d19
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the payload is still showing up in the CI even if there was no change to the library. This seems to be because the file sizes are not rounded and can sometimes be not very exact. Resulting in numbers like:
material_fesm_2014": 1004.1319999999998.To have a more readable output in the gulp task, the file sizes should be rounded. This also makes the diff comparsion in the Firebase function better.
See PRs like: #7169