Skip to content

docs(api): Fixes broken api docs post mat upgrade #7457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2017
Merged

docs(api): Fixes broken api docs post mat upgrade #7457

merged 1 commit into from
Oct 3, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Oct 1, 2017

This PR does the following:

  • Fixes directive selectors no longer matching after mat upgrade
  • Removes extraneous docs from the drawer class
  • Fixes empty paragraphs being inserted when no description provided
  • Fixes paragraphs inserting multiple times when designated with marked - I didn't see anywhere where we actually leveraged marked anyway.

@amcdnl amcdnl added the docs This issue is related to documentation label Oct 1, 2017
@amcdnl amcdnl self-assigned this Oct 1, 2017
@amcdnl amcdnl requested a review from jelbourn October 1, 2017 18:22
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 1, 2017
@amcdnl amcdnl mentioned this pull request Oct 1, 2017
Merged
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 1, 2017
@kara kara merged commit b6c0d20 into angular:master Oct 3, 2017
@amcdnl amcdnl deleted the api-doc-fixes branch October 3, 2017 13:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@devversion devversion Awaiting requested review from devversion

Assignees

@amcdnl amcdnl

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amcdnl @mmalerba @kara @googlebot