Skip to content

chore(tabs): remove unused initialized check #7476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2017
Merged

chore(tabs): remove unused initialized check #7476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/lib/tabs/tab-group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import {
AfterContentChecked,
AfterContentInit,
AfterViewChecked,
ChangeDetectionStrategy,
ChangeDetectorRef,
Component,
Expand Down Expand Up @@ -77,15 +76,12 @@ export const _MatTabGroupMixinBase = mixinColor(mixinDisableRipple(MatTabGroupBa
},
})
export class MatTabGroup extends _MatTabGroupMixinBase implements AfterContentInit,
AfterContentChecked, AfterViewChecked, OnDestroy, CanColor, CanDisableRipple {
AfterContentChecked, OnDestroy, CanColor, CanDisableRipple {

@ContentChildren(MatTab) _tabs: QueryList<MatTab>;

@ViewChild('tabBodyWrapper') _tabBodyWrapper: ElementRef;

/** Whether this component has been initialized. */
private _isInitialized: boolean = false;

/** The tab index that should be selected after the content has been checked. */
private _indexToSelect: number | null = 0;

Expand Down Expand Up @@ -210,14 +206,6 @@ export class MatTabGroup extends _MatTabGroupMixinBase implements AfterContentIn
this._tabLabelSubscription.unsubscribe();
}

/**
* Waits one frame for the view to update, then updates the ink bar
* Note: This must be run outside of the zone or it will create an infinite change detection loop.
*/
ngAfterViewChecked(): void {
this._isInitialized = true;
}

_focusChanged(index: number) {
this.focusChange.emit(this._createChangeEvent(index));
}
Expand Down